Inconsistent RP ammount with Alliance or Spy War

[Awesomdary]

Aug 20, 2014 23:51:30 GMT -5 Cory Trese said:

Okay, tested for a few more hours on this one and even wrote a new, very invasive test that looks at the saved game file using a secondary API to check every game cycle for differences. Now the prize winner for the slowest running test in the suite

Building that test I came to realize that the actual fix for the issue (5-6 releases ago) was to completely discard the entire political simulator data cache and rebuilt at the start of every turn.

This is computationally expensive, but also provides a 100% guarantee that aside from changes and variation determined by the game's rules, each turn will be fully compliant with the state in the saved game file.

So, how it works today

1. Load game => rebuild political simulator
2. Click next turn => rebuild political simulator
...
X. Click next turn => rebuild political simulator

The new test shows that this is probably not necessary and may be a waste of time, but it does completely and certainly fix any issues where turns and political changes are not correctly interacting, but those political changes are saved and then the simulator is purged from memory and then reloaded.

Based on all this testing, several in depth code reviews and new automated tests I cannot in any way come up with an explanation for this, outside of their being some deeper confusion about what constitutes the "wrong RP or Credit levels" in the original post.

I will continue to run the entire automated test suite several times each release, and if it ever flags an error of this type, I will quickly fix it and update this thread. If the bug exists it occurs in less than one in two million turns based on my search.

I hope this has been a helpful discussion. I suspect that the game is playing correctly, by the rules, and that for some reason or another you're expecting something different from the rules which is causing a suspicion of a defect in the software. I'd be happy to try to answer any rules questions you have, in this or another thread.

OK ... back to working on the next release! =)

Looking forward to the new release

I was wondering if you think that the 2 alliances I had at the time I remember clearest, could have caused the problems with the RP ammount?

And again Thanks so much for taking the time to see if you could find the bug, I will keep an eye on if the bug shows up again, but all things considered it isn't happening as much as it did when I first started playing which is a huge plus

[Awesomdary]

Hate to be a pain... But it's happened yet again, i have narrowed the problem down to happening when I haven't played the game in a day or so, and used the phone for lots of other things... I have some screenshots I can send you, I just need to upload them some time tomorrow I wish I could help by supplying the save games, because I suspect that that is where the problem lies... Perhaps in the way the treaties are saved And loaded after a long shut down where the game outs completely unloaded from the active memory?

Still using HTC one x plus and android 4.2.2

Your friendly neighborhood gamer

btw: Screenshots are from yesterday before I closed the app, and today then I decided to take a few turns before I went to bed.

[fallen]

@awesomedary - post the screenshots when you can. There is no difference in how the treaties are loaded with or without a break between turns.

[Awesomdary]

Aug 29, 2014 16:26:07 GMT -5 fallen said:

@awesomedary - post the screenshots when you can. There is no difference in how the treaties are loaded with or without a break between turns.

Well maybe not in theory, but praxis is another thing I will upload as soon as I can

[Awesomdary]

[Awesomdary]

As you can see the RP ammount isn't calculating correctly... and I still had 459 RP with 2 trade Alliances before I closed the game last night, and 397 after opening the game today... I just didn't manage to screen shot those treaties before closing the game yesterday