can't sell generated records

[shallowthought]

Had this happen a couple of times today:

Playing as merchant, buy enough of one resource to fill the ship's hold. This results in records being generated, filling the hold above 100%. It is not possible to sell these records without first selling something else currently in the hold, as the slider does not start at 0.

This was with the water fuel tank; it seems that the excess records use up space in the wf tank as it is not possible to get 25 wf in with full hold + excess records.

[Cory Trese]

Logging this as issue #725

[Cory Trese]

this will be fixed in the upcoming release. Took me a while to figure it out, but the root cause was an order of operations in that database code.

It was calculating the Record earned, awarding them and THEN completing the trade.

The fix is to complete the trade, update the Cargo data and then calculate records.

If you fill up your hold (tanks and all) you will earn less or no records, which is simply because no space is available to hold them.